NyxErinys/crunchy-cli
1
0
Fork 0
mirror of https://github.com/crunchy-labs/crunchy-cli.git synced 2026-01-21 04:02:00 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix spelling

Browse source
This commit is contained in:
bytedream 2023-12-03 00:15:57 +01:00
parent 8f77028fcb
commit 9ca3b79291
1 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crunchy-cli-core/src/utils/ffmpeg.rs
View file

@ -229,7 +229,7 @@ impl FFmpegPreset {
quality = Some(q) quality = Some(q)
} else { } else {
return Err(format!( return Err(format!(
"'{}' is not a valid ffmpeg preset (unknown token '{}'", "'{}' is not a valid ffmpeg preset (unknown token '{}')",
s, token s, token
)); ));
} }
@ -286,12 +286,10 @@ impl FFmpegPreset {
output.extend(["-c:v", "h264_nvenc", "-c:a", "copy"]) output.extend(["-c:v", "h264_nvenc", "-c:a", "copy"])
} }
FFmpegHwAccel::Apple => { FFmpegHwAccel::Apple => {
// Apple's Video Toolbox encoders ignore `-crf`, // Apple's Video Toolbox encoders ignore `-crf`, use `-q:v`
// use `-q:v` instead. It's on a scale of 1-100, // instead. It's on a scale of 1-100, 100 being lossless. Just
// 100 being lossless. Just did some math // did some math ((-a/51+1)*99+1 where `a` is the old crf value)
// ((-a/51+1)*99+1 where `a` is the old crf value) // so these settings very likely need some more tweaking
// so these settings very likely need some more
// tweeking.
match quality { match quality {
FFmpegQuality::Lossless => output.extend(["-q:v", "65"]), FFmpegQuality::Lossless => output.extend(["-q:v", "65"]),
FFmpegQuality::Normal => (), FFmpegQuality::Normal => (),